osmose-backend icon indicating copy to clipboard operation
osmose-backend copied to clipboard

Add analysers for France, 06

Open divulgacheur opened this issue 3 years ago • 10 comments

Based on Open Data from Région Sud and Métropôle Nice Côte d'Azur, add transports analysers.

divulgacheur avatar Jan 26 '22 18:01 divulgacheur

Add analyzers for Zest'Bus, Sillages and Envibus networks.

divulgacheur avatar Feb 03 '22 12:02 divulgacheur

We fixed the CI. Please rebase to get it working.

frodrigo avatar Feb 26 '22 13:02 frodrigo

Please, make a git rebase over master. Currently there is 70 touched file in this PR.

frodrigo avatar Feb 28 '22 11:02 frodrigo

@frodrigo is the rebase correct?

divulgacheur avatar Mar 08 '22 21:03 divulgacheur

Yes. look better https://github.com/osm-fr/osmose-backend/pull/1396/commits

frodrigo avatar Mar 08 '22 21:03 frodrigo

Can you review the linting issues ? https://github.com/osm-fr/osmose-backend/runs/5471185371?check_suite_focus=true

frodrigo avatar Mar 08 '22 21:03 frodrigo

Is it ok ?

divulgacheur avatar Mar 11 '22 16:03 divulgacheur

Is it ok ?

Linting is ok. Since there is lot of files. I want to run it myself before merging.

frodrigo avatar Mar 11 '22 17:03 frodrigo

@divulgacheur please, can you review the last comments, so we can done with this PR.

frodrigo avatar Mar 19 '22 19:03 frodrigo

@divulgacheur still interesting in getting this merged ?

  • You have to solve the review comment
  • Rebase and adjust the code to last merge refactoring https://github.com/osm-fr/osmose-backend/commit/2c438574634b32d102ff42e0e6ddff6ebd2dccdf https://github.com/osm-fr/osmose-backend/commit/e8c79acb82a3bf0e6c8a554ed771c1c7ed869cdc

frodrigo avatar Jun 19 '22 09:06 frodrigo

Closed in favor of #1612

frodrigo avatar Oct 22 '22 15:10 frodrigo