Yin-Yang icon indicating copy to clipboard operation
Yin-Yang copied to clipboard

Notification

Open freelyn opened this issue 3 years ago • 3 comments
trafficstars

OS notification and KDE color schemas plugin added

freelyn avatar Nov 22 '21 08:11 freelyn

I am thinking right now if Sound and notification (and maybe a dbus message in the future) should be implemented as simple plugins - technically these are also just functions that are called when the theme changes.

l0drex avatar Nov 22 '21 13:11 l0drex

@l0drex Initially I wanted to keep the plugins to system changes and not feedback for the program. However going forward it makes sense to blur this line and wrap play_sound & os_notificate with the plugin architecture which allows to more gradually control the states.

oskarsh avatar Nov 23 '21 12:11 oskarsh

Sorry for the long time getting no response. I have now taken the project over and did lots of changes in the beta branch that I had lying around (#68). This includes a simple notification plugin, but I like your method more. If you want to keep working on this, I would like you to rebase this onto the beta branch (maybe do a new pull request). If you don't have interest anymore, just tell me and I will merge these myself sometime.

l0drex avatar Sep 14 '22 17:09 l0drex

Ok, following issue: I don't want to add dbus as a dependency, since that is already implemented in pyside6. However, there is an issue: We can't create uints, so the method can't be called (see here). So instead, I am going to merge only the color scheme part. I don't think that's a big issue, since the notification is already implemented and works.

l0drex avatar Oct 28 '22 12:10 l0drex