Osip Fatkullin

Results 135 comments of Osip Fatkullin

I can try to implement this feature myself if it is needed

>The problem is that there are function in frameworks that work as `collect` for example `collectAsState` from Compose. Maybe if extension function on `Flow` is not returning `Flow`, consider it...

> Do you want to give it a try? Yes, I'll try to implement it

@gouri-panda, thanks for reminding! Yes, I'm planning to finish it on this week

> By looking at this rule API, I think we should add also the `restrictToReturnValueTypes` boolean config. > The rule should then check if `restrictToReturnValueTypes` is true and the returned...

> Yes that's correct. If enabled, the rule will flag only function which are returning the values types you listed. If this is not the case, then I misunderstood what...

> I would suggest to don't implement this logic. The two `restrict` should apply on top of each other and further restrict the set of return values we inspect. What...

Hm, according to examples from [docs](https://detekt.github.io/detekt/style.html#unnecessarylet) it is considered as compliant code 🤔 But I agree that `if` will look cleaner

For now Mimic supports only levels, classes, and items. Custom stats and mana are not supported yet, but it is planned.