Piotr Osiewicz

Results 106 comments of Piotr Osiewicz

/cc @as-cii , would love to get your take on this change.

Hey, thanks for a PR! we already have a setting section for tabs (see e.g https://github.com/zed-industries/zed/pull/2739); I think your change would fit in better in that.

@Liam-Breen We're using 1.5.1: `cargo tree -p libgit2-sys`: > libgit2-sys v0.14.2+1.5.1 We may have to wait until 1.8.0 is out: https://github.com/rust-lang/git2-rs/pull/1032 I'll keep an eye on it.

Hey, Thanks for reporting this issue. Currently we spawn static tasks (== tasks from tasks.json) without going through shell, which means that `$(pwd)` is interpreted literally. To work around that,...

For what it's worth, it seems like we'll have to spawn static tasks through shell, so your original example should work in the near future.

Hey, thanks for the report! It looks like this doesn't crash at runtime because `assert_unsafe_precondition` (which is what gets called to verify these preconditions in [from_raw_parts](https://github.com/rust-lang/rust/blob/b0696a5160711c068cb1f01b7437db7990d15750/library/core/src/slice/raw.rs#L99)) is a noop in...

If you're using nightly then I suppose this is a prime suspect as to why you're experiencing it: https://github.com/rust-lang/rust/pull/120594 I occasionally build with nightly, though I never run it. Edit:...

The patch you've provided looks fine to me, feel free to submit it as a PR :)

Hey, thanks for the PR! For what it's worth we've already profiled opening of large files internally; there was a recent PR that addressed some of the issues with loading...

I see what you're saying, but I don't think we should outright refuse to load a file that big. I think what @SomeoneToIgnore suggested makes sense; to have a popup...