Piotr Osiewicz
Piotr Osiewicz
Yes, I'll provide builds tomorrow. Note that #35270 is not going to land until next week.
I'm glad it works! And sorry for not providing the builds, I simply forgot. 😐
Hey, thanks for filling out this issue. For what it's worth, we always treat files with node shebang as JS files; see: https://github.com/zed-industries/zed/blob/main/crates/languages/src/javascript/config.toml#L4 I wonder if it's as easy as...
This could be due to us not sending DidOpen for multibuffer in some cases (which was an actual goal of https://github.com/zed-industries/zed/pull/21787). See also: https://github.com/llvm/llvm-project/blob/c1c50c7a3ef9ced4a9b01e0afd83b83d7060fff9/clang-tools-extra/clangd/ClangdServer.cpp#L519 If this is the case, the...
Should it be literally all excerpts or all excerpts that would be affected by the action? Because the latter is what we were trying to achieve
To be fair some of this (I think) is on RA side; when I've profiled my lovely 8k-diag use case (https://gist.github.com/osiewicz/89113b481504c719dc330ed02c51b4af) I've noticed that while building it (and emitting all...
> Have you tried out the performance of cargo clean --workspace with -Zbuild-dir-new-layout? No, I did not try `-Zbuild-dir-new-layout`. I'll do that and report back. > Are we really benefiting...
I am very happy to report that `-Zbuild-dir-new-layout` would make `cargo clean --workspace` take about a second on Zed codebase. :) This PR is currently at 2.6s. I think we...
I've rebased the existing implementation on top of #16304 - while we could push the perf further, I think this is good enough (after all, it gets us from 70s...