Or Shoval

Results 170 comments of Or Shoval

Addressed / responded to comments, thanks

As discussed offline, fixed to set the IPAMClaim network name as the one from the NAD.Spec.Config name https://github.com/containernetworking/cni/blob/main/SPEC.md#configuration-format This is the one that OVN controller need to know events about,...

addressed latest round comments

simplified a bit GetNetworkToIPAMClaimParams

Added unit tests (might not be final yet)

Addressed comments (the 2nd push is just a little name change)

seems the `SKIP_PATTERN="^(docs/)|(OWNERS|OWNERS_ALIASES|.*\.(md|txt))$"` didnt work here well https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/11246/pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network/1757736377035788288

> I think it did, but this PR was (I asume) part of a batch which touched another file: > > ``` > + CI_GIT_ALL_CHANGES='OWNERS_ALIASES > pkg/virt-handler/dmetrics-manager/dmetrics-manager.go' > ``` >...

Thanks Hold can be removed I think we can remove this please from PR desc ``` Before this PR: Cannot import volumes from GCS storage After this PR: Can import...

Once KUBEVIRT_E2E_RUN_ALL_SUITES is dropped https://github.com/kubevirt/kubevirt/pull/8991 should be reverted please