Or Shoval
Or Shoval
> @oshoval This PR needs to wait for this issue to be resolved: [kubernetes/kubernetes#134569](https://github.com/kubernetes/kubernetes/issues/134569) > > There is a PR open for it [kubernetes/enhancements#5669](https://github.com/kubernetes/enhancements/pull/5669) awaiting reviews. Once this PR is...
> @oshoval yeah it makes sense to iterate faster, in that case can you avoid taking a dependency on `"k8s.io/dynamic-resource-allocation/deviceattribute"` and hardcode the name like it was before? since we...
> > if not, you prefer to hardcode it as resource.kubernetes.io/pciAddress ? > > yes this would be my preference, out of abundance of safety. This is to make sure...
done https://github.com/kubevirt/kubevirt/pull/16249#discussion_r2581676112
/hold seems it doesnt work with `pciBusID`, checking maybe it is just because of the kubelet bug note please that i didnt test the `mDevUUID`, maybe better to delegate it...
/hold cancel it works, my mistake
Thanks for the help here Sebastian, all
/hold cancel all is passing
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-network-1.4