osher

Results 105 comments of osher

c8 + vitest: Some suites get covered other suites ...dont?

@bcoe - I'd really appreciate it if you could take a look, or direct me to who can help Thanks for all the good work! :)

From version 2 - `.on(name, handler)` returns a promise....??

I also see that `client.serverInfo.redis_version` and such have moved to `__redisClient.serverInfo.redis_version` is there a stated accessor to the server info I should use, or is it legit to access `__redicClient`...

From version 2 - `.on(name, handler)` returns a promise....??

anybody home?

From version 2 - `.on(name, handler)` returns a promise....??

🤔

signature fails when signing URLs that include the character '*'

@inancgumus - here are the parts I can share. It's edited - I removed any secret sauce that could be IP of my client, and made the flow straight forward......

fix: violent crash in stack-trace parsing

@sheremet-va - thanks for your reply If I wanted to support any type and give special treatment to Array and function, I would do something like: ```patch export function parseStacktrace(...

fix: violent crash in stack-trace parsing

First - wow. you're a fast one. I updated my comment above to be clearer... saw you already replied after I finished please check it... Anyway - If we don't...

fix: violent crash in stack-trace parsing

Would you please consider the case for a moment? You run a test, you get a fail and you don't get a stack trace. No failed assertion, no stack trace,...

fix: violent crash in stack-trace parsing

> Don't patch built-ins if you want to see the stack trace. It's that simple. That's what the project requirements are... This is not even the project per-se, it's using...

fix: violent crash in stack-trace parsing

> You can use it, you just won't see the stack trace And not know what the test failed for? Sir, I'm sorry, this is a basic expectation from a...