osgi-test icon indicating copy to clipboard operation
osgi-test copied to clipboard

Update Jupiter for Eclipse 09-23

Open maho7791 opened this issue 1 year ago • 3 comments

  • Updated Junit Jupiter to work with Eclipse 09-23 IDE
  • use bnd 7.0.0 to build

maho7791 avatar Nov 06 '23 13:11 maho7791

Hey @maho7791 , thanks for the PR! What's the end goal here, if you don't mind me asking? I'm surprised that osgi-test doesn't already work with Eclipse 09-23?

kriegfrj avatar Nov 06 '23 13:11 kriegfrj

The latest JUnit Laucher in the PDE 09-23 expects Jupiter 5.10. to work. If OSGi Test uses a dependency lower than 5.10 you end up MethodNotFound exceptio. This PR is just for completeness, so that OSGi Test also works with 5.10. If I think about it, should we consider also increase the jupiter and platform-compile-version?

maho7791 avatar Nov 06 '23 13:11 maho7791

The latest JUnit Laucher in the PDE 09-23 expects Jupiter 5.10. to work. If OSGi Test uses a dependency lower than 5.10 you end up MethodNotFound exceptio.

If it's not too difficult, can you put the stack trace of that exception in here somewhere for posterity?

This PR is just for completeness, so that OSGi Test also works with 5.10.

I think that the problem is not that OSGi Test won't work with 5.10 - I think it will as the JUnit team are pretty good about maintaining backward compatibility. The problem seems to be that the Eclipse 09-23's JUnit integration requires JUnit Platform >=1.10. So you can't run the tests inside the IDE. I'm guessing that they probably still work from Maven command line though,

If I think about it, should we consider also increase the jupiter and platform-compile-version?

I am not against increasing the baseline version that we compile against if there is a specific need for a newer feature in the newer version. However, in the absence of such a need I am hesitant.

So if changing the runtime version fixes your problem with the IDE integration, perhaps we should stick with that for this PR. We can always revisit bumping up the compile version at some point if/when there is a case to be made to use a newer feature.

kriegfrj avatar Nov 07 '23 00:11 kriegfrj