ConfigurationAdmin Assertions

[stbischof]

Assertions and Conditions on CofigurationEvent (service.cm)

[codecov-commenter]

Codecov Report

Merging #355 (8f27069) into main (831dcf1) will increase coverage by 0.82%. The diff coverage is 85.29%.

@@             Coverage Diff              @@
##               main     #355      +/-   ##
============================================
+ Coverage     64.14%   64.96%   +0.82%     
- Complexity      696      757      +61     
============================================
  Files            81       90       +9     
  Lines          2521     2623     +102     
  Branches        284      287       +3     
============================================
+ Hits           1617     1704      +87     
- Misses          830      844      +14     
- Partials         74       75       +1     

Impacted Files	Coverage Δ
...gi/test/assertj/cm/ConfigurationBddAssertions.java	0.00% <0.00%> (ø)
...i/test/assertj/cm/ConfigurationSoftAssertions.java	0.00% <0.00%> (ø)
.../cm/configuration/AbstractConfigurationAssert.java	80.00% <80.00%> (ø)
.../cm/configurationevent/ConfigurationEventType.java	87.50% <87.50%> (ø)
.../assertj/cm/configuration/ConfigurationAssert.java	100.00% <100.00%> (ø)
...ertj/cm/configuration/ConfigurationConditions.java	100.00% <100.00%> (ø)
...urationevent/AbstractConfigurationEventAssert.java	100.00% <100.00%> (ø)
...m/configurationevent/ConfigurationEventAssert.java	100.00% <100.00%> (ø)
...nfigurationevent/ConfigurationEventConditions.java	100.00% <100.00%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 831dcf1...8f27069. Read the comment docs.

[stbischof]

@bjhargrave any idea what here happened? https://github.com/osgi/osgi-test/runs/3028364006?check_suite_focus=true#step:4:816

It is also not clear to me why CodeCov does not find any changes.

[bjhargrave]

@bjhargrave any idea what here happened?

Looks like the test hung. It could just have been problems with the github actions servers. The internet is flaky :-)

[stbischof]

i missed to add this to the cibuild.yml for the new project. now the codecov should work.

    - name: Upload "assertj.cm" coverage to Codecov
      if: ${{ matrix.codecov }}
      uses: codecov/codecov-action@v1
      with:
        file: ./org.osgi.test.assertj.cm/target/site/jacoco-it/jacoco.xml
        name: assertj.cm

[stbischof]

@bjhargrave This PR Seems complete to me. Could you please review?

[stbischof]

@bjhargrave could you please review again?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be closed if no further activity occurs. If you intend to work on this pull request, please reopen the PR. Thank you for your contributions.

[github-actions[bot]]

This pull request has been automatically closed due to inactivity. If you are still interested in contributing this, please ensure that it is rebased against the latest main branch, all review comments have been addressed and the build is passing.