ScraperFC icon indicating copy to clipboard operation
ScraperFC copied to clipboard

Published 20 hours ago • verified publisher icon oseymour

Understat dataframe.append deprecated

Open rubeenvm2 opened this issue 1 year ago • 2 comments

From Understat.py: 634 game_states = game_states.append( 635 pd.DataFrame(row_array.reshape(1,-1)),#, columns=game_states.columns), 636 ignore_index=True 637 ) Being game_states a df, I think append is deprecated in pandas, should be changed to concat().

rubeenvm2 avatar Jan 18 '24 21:01 rubeenvm2

Hey @rubeenvm2! Thanks for raising this. I haven't fixed these in the past because the deprecation hadn't become effective. I don't have any time for ScraperFC right now, I'm working on other projects/life things. I'll update the append() calls to concat() when I get back to ScraperFC though!

oseymour avatar Mar 10 '24 23:03 oseymour

Following up on this: this would be a good community contribution, if somebody wanted to go through and fix these

oseymour avatar Mar 12 '24 03:03 oseymour

Updated in v3.0.0.

oseymour avatar Jun 24 '24 03:06 oseymour