peek-and-pop icon indicating copy to clipboard operation
peek-and-pop copied to clipboard

What needs to be done

Open osdnk opened this issue 4 years ago • 3 comments

Hey, At the first place, I need to say sorry. I was probably trying to move too fast and released this library at the Org too fast. Since we're really caring about the quality of code here, probably having a not finished library here is not a good idea. Also, I lost my motivation for developing it. I'm not using it any of my projects so that's why I'm writing this issue. I want to make transparent that I'm happy with this lib thriving but I cannot offer me coding it now – sorry, maybe someday! Also, recently I had a VC with @thib92. He offered his involvement with my assistance (I have some time for reviewing things).

So here are missing parts:

  • [ ] https://developer.apple.com/documentation/uikit/uicontextmenuinteractiondelegate use new API instead of the old one (https://developer.apple.com/documentation/uikit/uipreviewaction)
  • [x] Use Yoga nodes. Now I'm making some dirty hacks with native reparenting which is a very bad solution. We need to have extra Yoga evaluation to determine the size of the content based on style. Probably native stack by @kmagiera in RN-Screens might be a good inspiration. I'm happy with his patterns.
  • [ ] Write docs. Real documentation with a good example and well-documented API
  • [ ] Verify with iPhone 13 (haptic touch instead of pressure). I'm not sure with these differences but it needs to be verified.
  • [ ] Release to NPM. I can help with providing passes or do it on my own.

So hands-on! Let's make it workable, cause it's still a pattern many people missing. I'm super excited with @thib92 on board!

osdnk avatar Sep 24 '19 18:09 osdnk