Michał Osadnik comments

Results 47 comments of


                                            Michał Osadnik

fix: drawer position on window resize

Hi! Thanks for the PR. Unfortunately, we do not want to observe the window size, but the frame size, so we should not use `useWindowDimesions`. So... I think we should...

feat: rewrite drawer for a new RNGH API

@satya164 I addressed the problem

fix: Registered listener not found when mounting and unmounting

@g1d5ny Thanks for the PR. Please elaborate on the issue you solve. This seems to be a bit cryptic in the current shape

fix: remove NonNullable to fix recursive infer in PathConfigMap

Hi @johankasperi, Thanks for the PR! Can you please rebase and fix the CI? Also, can you add tests (use `__typechecks__` folder).

feat(drawer): to allow developer to override styles for DrawerItem Li…

Can you add some motivation for ur changes?

Update types.tsx

Hi, @nikmantulenko Thanks for the PR! I think this might be a nice approach, but at this stage, this seems to be a very atomic change, whereas there are multiple...

Add the ability to "retain" a dismissed screen, to support iOS Picture In Picture overlays.

Actually, ignore my comment about adding the example. It's not possible now

Add docs for ProgressiveListView

I have the same case :) I need a list to show something a be responsive quickly and then load the rest of a list of complex items

Content is overflowing at the bottom which results in a content leak on Notch phones

Thanks, I have no opinion how to deal with now, but I'm going to figure it out soon.

Content is overflowing at the bottom which results in a content leak on Notch phones

I think that @Eyesonly88 is good. Need to dig into it a bit