TabuRei icon indicating copy to clipboard operation
TabuRei copied to clipboard

Adding an expand button

Open DragoVeizen opened this issue 4 years ago • 7 comments

fixes #45 Button still to be customised and placed accordingly unknown s2

DragoVeizen avatar Aug 09 '21 18:08 DragoVeizen

Will work on the changes and get back to you

DragoVeizen avatar Aug 10 '21 11:08 DragoVeizen

Implemented all the changes and fixes i was instructed to. image image Reviews and suggestions are welcome.

DragoVeizen avatar Aug 14 '21 06:08 DragoVeizen

@DragoVeizen Found some bugs during testing.

  1. When we have more than one tab groups, clicking on the expand/collapse button only exapnds/collapses the latest tab group. Even after I click on other tab groups, it modifies the latest one.
  2. I'm not sure if it's only happening for me(@daemon1024 @akshgpt7 Please confirm), but the popup doesn't show any tabs in it. It's just empty.

@DragoVeizen Since you haven't touched anything from popup.js, I don't think you should worry about the 2nd issue now. Just focus on the first one :)

aayushmau5 avatar Aug 14 '21 13:08 aayushmau5

Oh okay..ill check it out :)

DragoVeizen avatar Aug 15 '21 08:08 DragoVeizen

Hey, @DragoVeizen any updates on this?

akshgpt7 avatar Aug 27 '21 01:08 akshgpt7

No not really i was investing most of my time somewhere else ill get back to this in a day or two and hopefully make it right.

DragoVeizen avatar Aug 27 '21 16:08 DragoVeizen

cool, no problem, just checking :D

akshgpt7 avatar Aug 27 '21 17:08 akshgpt7