Otto van der Schaaf

Closing this in an effort to clean up stale pull requests (but feel free to re-open if you want to pick this up again).

Can you reproduce that log message?

Http 304 indicates that the resource was not modified. That's not an error, I think it is fine.

resource_namer.cc lives here: https://github.com/apache/incubator-pagespeed-mod/blob/master/net/instaweb/rewriter/resource_namer.cc You'd have to build psol from source to change it and link ngx_pagespeed against it. See https://github.com/apache/incubator-pagespeed-mod/wiki/Development on how to pull that off, and feel free...

I wonder, is there any specific configuration for the path that won’t be optimized?

Can you add this line?: ``` pagespeed EnableFilters responsive_images; ``` Hopefully ngx_pagespeed will emit comments in html mentioning why it backs out of optimization.

@jmarantz that makes sense, I'll look into that.

With some fiddling this produces an nginx binary for me: ``` #!/bin/bash set -x NPS_VERSION=1.14.33.1-RC1 NPS_RELEASE_NUMBER=1.14.36.1 PS_NGX_EXTRA_FLAGS=--with-cc-opt=-Wno-error wget -O- https://github.com/apache/incubator-pagespeed-ngx/archive/refs/tags/v${NPS_VERSION}.tar.gz | tar -xz nps_dir=$(realpath $(find . -name "*pagespeed-ngx-${NPS_VERSION}" -type d))...

We're working to produce an apache incubator release for mod_pagespeed; updating ngx_pagespeed to leverage that new version and ship a new release based on that will be low hanging fruit.

As far as I know no one is planning to mark that as production ready at this time, mostly because it’s not clear how many people are running that in...