Embed icon indicating copy to clipboard operation
Embed copied to clipboard

Published 20 hours ago • verified publisher icon oscarotero

Embedding video's with controls

Open lenvanessen opened this issue 4 years ago • 1 comments

Hi there,

When we embed something from giphy, it retuns a <video> element. However, we can't pass any custom variables to the HTML function as far as I can see.

Would be nice to be able to pass controls in there so that the videos can be used for instance.

lenvanessen avatar Jun 24 '20 13:06 lenvanessen

This code is generated here: https://github.com/oscarotero/Embed/blob/master/src/Detectors/Code.php#L64 Maybe there could be an option code:video_attributes allowing to pass random attributes to the video, in the same way that oembed:query_parameters option.

Do you want to work on a pull request?

oscarotero avatar Jun 24 '20 22:06 oscarotero