Oscar Levin comments

Results 105 comments of


                                            Oscar Levin

Ensure xml:id restriction works with `generate`

The issue is likely only showing up on projects that have some images with `xml:id` and some without. Will look at more.

Ensure xml:id restriction works with `generate`

I should have this fixed by the end of the day (after almost completely rewriting the generate method, fun fun fun). Once it is done, I will release 2.1

Ensure xml:id restriction works with `generate`

Okay, I have refactored the generate function in #622, and I *think* this solves any issues that were present. Tested all the cases I could think of (but did not...

Ensure xml:id restriction works with `generate`

I agree! Need to spend some time thinking about a good DOE for capturing a large percentage of the use cases.

warn when using `xi:include` without `xmlns:xi="http://www.w3.org/2001/XInclude"`

This would be a good addition to the lints. On Tue, Jul 30, 2024, 3:42 PM Steven Clontz ***@***.***> wrote: > > https://github.com/TeamBasedInquiryLearning/library/actions/runs/10168844289/job/28126187184 > > — > Reply to this...

can't detect requirements.txt from subfolder

Okay, I no longer think it is the subfolder, but that I specified `pretext >= 2.6.1` is `requirements.txt`. But this should also be supported.

can't detect requirements.txt from subfolder

Closing as won't fix.

Only install github extras when in a directory tracked by git

This was closed by #902

Use oscarlevin:full by default in codespace

I'd like to think about this some more. It is less about the extra startup time than it is about the storage limit imposed by codespaces (and the new scrutiny...

Use oscarlevin:full by default in codespace

Okay, I think you are right. We will try it this way for now.