lhttpc icon indicating copy to clipboard operation
lhttpc copied to clipboard

New features and bug fixes

Open fdmanana opened this issue 13 years ago • 6 comments

Hi Oscar,

The following commits add the following features:

  1. Automatic support for HTTP basic auth;

  2. Support IPv6;

  3. Support HTTP proxies;

  4. Support for a limit in the pool (lhttpc_manager);

  5. Allow clients to use different pools (lhttpc_manager instances)

  6. and 2) also fix and enhance lhttpc_lib:parse_url/1.

Best regards, Filipe Manana

fdmanana avatar Oct 12 '11 15:10 fdmanana

Hello Filipe,

Really nice modifications. I guess it would get better chances of a merge if the pull request was split into several smaller ones (for example, one per each separate modification).

Oscar, do you have any comments on the mods?

zaa avatar Dec 13 '11 03:12 zaa

Hi,

I saw that you sent this to ESL. That's probably for the better, since I've been really busy with other things. I was intending to have a look during the holidays :)

I did have some initial thoughts about the connection limit when we developed lhttpc. My idea was to have that as a separate module, kind of like a seaphore, so that it wouldn't make lhttpc_manager more complex. I haven't looked too much at your changes but as far as I can see you've implemented the changes for connection limits in lhttpc_manager.

/Oscar

oscarh avatar Dec 20 '11 14:12 oscarh

That's an interesting idea Oscar. Thanks

fdmanana avatar Dec 20 '11 20:12 fdmanana

+1 for merging

astro avatar Apr 16 '12 23:04 astro

@astro All those changes were merged into Erlang Solutions' lhttpc repository:

https://github.com/esl/lhttpc

regards

fdmanana avatar Apr 17 '12 12:04 fdmanana

That is great. I hope they will tag a release some day.

Thanks.

astro avatar Apr 17 '12 14:04 astro