lhttpc
lhttpc copied to clipboard
New features and bug fixes
Hi Oscar,
The following commits add the following features:
-
Automatic support for HTTP basic auth;
-
Support IPv6;
-
Support HTTP proxies;
-
Support for a limit in the pool (lhttpc_manager);
-
Allow clients to use different pools (lhttpc_manager instances)
-
and 2) also fix and enhance lhttpc_lib:parse_url/1.
Best regards, Filipe Manana
Hello Filipe,
Really nice modifications. I guess it would get better chances of a merge if the pull request was split into several smaller ones (for example, one per each separate modification).
Oscar, do you have any comments on the mods?
Hi,
I saw that you sent this to ESL. That's probably for the better, since I've been really busy with other things. I was intending to have a look during the holidays :)
I did have some initial thoughts about the connection limit when we developed lhttpc. My idea was to have that as a separate module, kind of like a seaphore, so that it wouldn't make lhttpc_manager more complex. I haven't looked too much at your changes but as far as I can see you've implemented the changes for connection limits in lhttpc_manager.
/Oscar
That's an interesting idea Oscar. Thanks
+1 for merging
@astro All those changes were merged into Erlang Solutions' lhttpc repository:
https://github.com/esl/lhttpc
regards
That is great. I hope they will tag a release some day.
Thanks.