Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

I tested this locally and it seems to solve #23325 as well. Tried to add a CI-file building an sdist and printing the resulting version number. Not sure how worthwhile...

It seems like cibuildwheel cannot first build an sdist. Current version uses build and then installs both sdist and wheel and checks the version number.

> Is this a blocking issues for 3.6? Hard to say. I'd say that it is rather non-controversial. * Removing `setuptools_scm_git_archive` and modifying `.git_archival.txt` are cookbook recipes. This is primarily...

Please add tests for these changes. You can example generate a test image as: ``` ax = plt.gca() im = AxesImage(ax) z = np.arange(12, dtype=float).reshape((4, 3)) im.set_data(z) ``` and then...

I guess it may be possible to iterate over the collection objects similar to https://github.com/matplotlib/matplotlib/blob/4f5cacfde9024076d9ab0cb6ad1c9a7cf352d5f9/lib/matplotlib/axes/_base.py#L2453-L2460 but there may be some obstacles (including being slow for large collections...).

Ahh, I didn't fully get the reason behind the error. Much clearer test suggested indeed.

I had a look at the generated SVG and the main steps seems to be: In the svg-tag ``` xmlns:ns3="http://www.iki.fi/pav/software/textext/" ``` In the object containing the equation paths ``` ns3:version="1.6.1"...

Preliminary tests show that it sort of works. I noted that there is an additional group of the text object so the actual equation object is inside another object without...

> Oh, also, do you need text; can you set `remove_text=True`? I also test `label_mode`, so the text is required to see the effect.

> I suggest to connect the colorbars with the respective axes images, so that they are not empty. C.f. https://matplotlib.org/stable/gallery/axes_grid1/demo_axes_grid.html > > Also, not sure if it’s worth it here,...