firebase-ruby icon indicating copy to clipboard operation
firebase-ruby copied to clipboard

Restructuring the Gem

Open EdwinRozario opened this issue 7 years ago • 3 comments

  • Client class moved to a separate file.
  • New class Request created to handle http interactions with firebase.

EdwinRozario avatar Jan 29 '18 02:01 EdwinRozario

Hi Edwin, sorry about the delay. I think that my problem with this PR is that it does too much for the benefit provided. If you're interested in adding support for additional Firebase products, I'd rather look at specific PRs for that rather than a general overhaul of the entire gem. For instance, changes to the new hash syntax will break old Ruby compatibility. It's fine to do that, but we're not getting much benefit out of doing that right now.

vincentwoo avatar Feb 14 '18 01:02 vincentwoo

@vincentwoo The reason i have separated classes is to make future addition of other Firebase services easier.

EdwinRozario avatar Feb 21 '18 00:02 EdwinRozario

I know, but unless we have an active plan to do that work, we are basically asking all our downstream users to refactor their code for no gain.

vincentwoo avatar Feb 21 '18 00:02 vincentwoo