cbsyst

cbsyst copied to clipboard

Fix dependencies

1

The move to setup.cfg dropped the dependencies and the sdist on PyPI is broken at the moment. This should fix it. I also moved the find packages to the setup.cfg....

ocefpaf

CO2 can become negative under high pH, high TA: ```python cb.Csys(pHtot=10.5, TA=2300).CO2 # array([-9.01237887e-06]) ``` Csys hangs if pH is too high: ```python cb.Csys(pHtot=11, TA=2300) # does not run ```

oscarbranson

Alternative Constants?

4

## Would other constants be useful? At present, there are no options for different constants in cbsyst. Do people want/need choices? Request constants in the comments below. If they get...

oscarbranson

## Implement Alternate [Mg] and [Ca] corrections - [ ] [Ben-Yaakov and Goldharber (1973)](http://www.sciencedirect.com/science/article/pii/0011747173900442) - [ ] [Tyrrell and Zeebe (2004)](http://www.sciencedirect.com/science/article/pii/S0016703704001681) - [ ] PHREEQC Pitzer model?

oscarbranson

Currently using CO2SYS method. Consider others: - As in LOSCAR ([Follows et al, 2006](http://dx.doi.org/10.1016/j.ocemod.2005.05.004)). - [SolveSAPHE](http://orbi.ulg.ac.be/bitstream/2268/155792/1/gmd-6-1367-2013.pdf)

oscarbranson

Separate T/S/P input & output conditions.

3

Currently, input and output conditions are the same. It would be good to be able to separate input/output T, S, P conditions. This should be relatively simple and inexpensive, and...

oscarbranson

Comparison to CO2SYS

2

After [Orr et al (2015)](http://www.biogeosciences.net/12/1483/2015/bg-12-1483-2015.pdf).

oscarbranson

Vectorising

3

A lot of the solvers in [carbon_fns.py](https://github.com/oscarbranson/cbsyst/blob/master/cbsyst/carbon_fns.py) would be sped up by vectorising. At the moment, most serially apply zero_finder functions to solve for H. The following functions in [cbsyst/carbon_fns.py](https://github.com/oscarbranson/cbsyst/blob/master/cbsyst/carbon_fns.py)...

oscarbranson

**This is shelved for the moment - revisit later if it becomes an issue** At the moment, the Xsys functions can only take single combinations of input parameters. It might...

oscarbranson

Error Propagation

2

Implement it... using uncertainties package?

oscarbranson