Oscar.jl icon indicating copy to clipboard operation
Oscar.jl copied to clipboard

[ToricVarieties] Shorthands for hirzebruch surface and del Pezzo surface

Open HereAround opened this issue 5 months ago • 5 comments

As pointed out by @micjoswig in https://github.com/oscar-system/Oscar.jl/pull/3996, for the current constructor hirzebruch_surface(::Type{NormalToricVariety}, r::Int), the first argument is currently obsolete. This PR introduces a shorthand hirzebruch_surface(r::Int).

A similar situation exists for del_pezzo_surface, and I have taken the liberty to propose a similar short hand.

We also have the following specialized constructors:

  • affine_space(::Type{NormalToricVariety}, var_names::AbstractVector{<:VarName})
  • affine_space(::Type{NormalToricVariety}, d::Int)
  • projective_space(::Type{NormalToricVariety}, d::Int)
  • weighted_projective_space(::Type{NormalToricVariety}, w::Vector{T}) where {T <: IntegerUnion}

I could not find instances, where those constructors are called with a first argument different from NormalToricVariety. (But of course, I could have overlooked those instances...) In https://github.com/oscar-system/Oscar.jl/pull/3996, I was therefore carried away to propose short hands for all of these constructors. This is (at least not yet) done in this PR, as this seems to require discussion and so I removed this proposed change after being alerted to this by @lgoettgens .

This PR aims to clarify the situation and to resolve it.

HereAround avatar Aug 28 '24 14:08 HereAround