Finish formatting of PolyhedralGeometry

[lkastner]

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.28%. Comparing base (8c0ab30) to head (ea9e79d).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3626   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files         580      580           
  Lines       79352    79352           
=======================================
  Hits        64499    64499           
  Misses      14853    14853           

Files	Coverage Δ
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl	100.00% <ø> (ø)
...xperimental/LieAlgebras/test/iso_gap_oscar-test.jl	83.33% <ø> (ø)
src/InvariantTheory/affine_algebra.jl	98.80% <ø> (ø)
...edralGeometry/Polyhedron/standard_constructions.jl	97.25% <ø> (ø)
src/PolyhedralGeometry/Polyhedron/properties.jl	86.50% <85.71%> (ø)

[lkastner]

In general I would rather avoid anything were we manually interfere with the formatter since this always entails mentioning this in PRs and explaining it to devs. One main goal of the formatting tests is to reduce our work when reviewing PRs. It has the added benefit that there is an automated way for devs to fix their formatting. The many comments on formatting can seem a bit like micromanagement and be quite discouraging.

[joschmitt]

What is the plan now? I would think that with every set of formatting rules, there will be some situation where the result is not optimal. And there will always be somebody who doesn't like something about the current style (I personally would put more white space than the formatter for example). In case you are waiting for opinions: I can live with it as it is now. If there is an option that magically aligns the matrices as we want, great. align_matrix seems not to be it; it even adds white space with every run for me, so the tests won't work.