Oscar.jl icon indicating copy to clipboard operation
Oscar.jl copied to clipboard

Ideal gens merge

Open AlexD97 opened this issue 1 year ago • 1 comments

Introducing Gröbner bases/standard bases and ideal generating systems, as discussed. This PR contains the necessary amount of changes and resulting streamlining, while staying as close as possible to the status quo. Generalizations and more functionality for ideal generating systems to come as next steps.

AlexD97 avatar Oct 05 '22 17:10 AlexD97

The elements of a GB are referred to using gens: julia> gens(groebner_basis(J)) How about replacing gens by elements?

Any thoughts somebody?

wdecker avatar Oct 08 '22 17:10 wdecker

The elements of a GB are referred to using gens: julia> gens(groebner_basis(J)) How about replacing gens by elements?

Any thoughts somebody?

I would say that groebner_basis(J) should be iterable, and groebner_basis(J)[1] should work and collect(groebner_basis(J)).

julia> S  = Set([1,2,3,4])
Set{Int64} with 4 elements:
  4
  2
  3
  1

julia> collect(S)
4-element Vector{Int64}:
 4
 2
 3
 1

We could allow both gens(groebner_basis(J)) and elements(groebner_basis(J)). Can't hurt. Maybe one user searches for gens and the other likes elements better. This way both are happy.

simonbrandhorst avatar Oct 13 '22 18:10 simonbrandhorst

Let me have one another look in 12 hours.

tthsqe12 avatar Oct 24 '22 19:10 tthsqe12

I see that that the fields isGB, ord and keepordering in the old BiPolyArray are moved to the new IdealGens. Any comments on the efficacy of this two-level approach? old:

BiPolyArray:
  Ox
  O
  Sx
  S
  isGB
  ord
  keepordering

new:

BiPolyArray:
  Ox
  O
  Sx
  S

IdealGens:
  gens::BiPolyArray
  isGB
  ord
  keepordering

tthsqe12 avatar Oct 25 '22 08:10 tthsqe12

As far as I understood there will soon be more (meta) data added to IdealGens than just the ordering. I also raised the point of efficiancy some months ago but maybe @jankoboehm can give us more insight on the future plans for IdealGens.

ederc avatar Oct 25 '22 08:10 ederc

in any case, merge is fine with me

tthsqe12 avatar Oct 25 '22 08:10 tthsqe12