Oscar.jl icon indicating copy to clipboard operation
Oscar.jl copied to clipboard

msolve -> AlgebraicSolving

Open ederc opened this issue 2 years ago • 2 comments

Introduces AlgebraicSolving.jlto Oscar. This package replaces the direct interface to msolve and will allow an easier deployment of upcoming features and algorithms based on msolve.

ederc avatar Jul 21 '22 19:07 ederc

On Thu, Jul 21, 2022 at 12:12:00PM -0700, ederc wrote:

Introduces AlgebraicSolving.jlto Oscar. This package replaces the direct interface to msolve and will allow an easier deployment of upcoming features and algorithms based on msolve. You can view, comment on, or merge this pull request online at:

Can you please also provide a link to AlgebraicSolving.jl? I cannot find it.

https://github.com/oscar-system/Oscar.jl/pull/1474

-- Commit Summary --

  • introduces AlgebraicSolving to Oscar
  • adds f4 from AlgebraicSolving
  • adjusts tests for f4
  • adds multivariate polynomial system solver from AlgebraicSolving
  • tests renamed from msolve to solving
  • updates AlgebraicSolving version
  • remove old msolve files
  • removes @show
  • remove msolve_jll dependencies

-- File Changes --

M Project.toml (4)
M src/Oscar.jl (6)
M src/Rings/groebner.jl (66)
D src/Rings/msolve/f4.jl (111)
D src/Rings/msolve/interface.jl (217)
D src/Rings/msolve/msolve.jl (195)
A src/Rings/solving.jl (54)
M src/imports.jl (1)
M test/Rings/groebner-test.jl (26)
D test/Rings/msolve-test.jl (67)
A test/Rings/solving-test.jl (29)

-- Patch Links --

https://github.com/oscar-system/Oscar.jl/pull/1474.patch https://github.com/oscar-system/Oscar.jl/pull/1474.diff

-- Reply to this email directly or view it on GitHub: https://github.com/oscar-system/Oscar.jl/pull/1474 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

fieker avatar Jul 22 '22 08:07 fieker

When you resolve the conflicts, I will merge. Looks good to me.

simonbrandhorst avatar Oct 08 '22 19:10 simonbrandhorst