compliance-trestle icon indicating copy to clipboard operation
compliance-trestle copied to clipboard

address task cis-xlsx-to-oscal-catalog shortcomings

Open degenaro opened this issue 1 year ago • 1 comments

Describe the bug

task cis-xlsx-to-oscal-catalog shortcomings:

  • searching for columns by name may fail because not all columns are checked; column count is one short
  • when normalizing data, input types that are not string (such as int, float) are not stringified causing, for example, search for '.' to fail for data in cell of column section # due to the invalid type
  • when a failure occurs, the failing row number is not given
  • some columns, such as v7 IG1, should be optional
  • if the section # column data values start with an alphabetic, then 'CIS-" should not be added as prefix
  • allow specification of prefix (e.g. "CIS-") on command line (or config file), which take precedence if specified
  • additional non-required columns should be detected and added as properties
  • allow specification of ns on command line (or config file)
  • required columns are: section #, recommendation #, title
  • required data values: section #, title only
  • if recommendation # value specified, then description value required

To Reproduce

Steps to reproduce the behavior:

  • try an xlsx file with profile as the last column
  • try an xlsx file with an int value 1 in the section # column
  • try an xlsx file with column v7 IG1 omitted

Expected behavior

The above failure cases should no longer fail.

Screenshots / Logs.

N/A

Environment

N/A

degenaro avatar Feb 23 '24 19:02 degenaro