gooderp_addons icon indicating copy to clipboard operation
gooderp_addons copied to clipboard

Published 20 hours ago • verified publisher icon osbzr

fix: fix bug on check vulnerable browser

Open GalliumWang opened this issue 3 years ago • 4 comments

GalliumWang avatar Jan 24 '22 10:01 GalliumWang

Hey @GalliumWang, can you explain the bug?

jonasstrehle avatar Jan 24 '22 10:01 jonasstrehle

Hey @GalliumWang, can you explain the bug?

image

with the underlined check statement, the second else statement will never be excuted, which is used for checking browsers that not vulnerable to this favicon attack.

GalliumWang avatar Jan 25 '22 07:01 GalliumWang

Hey @GalliumWang, can you explain the bug?

Maybe line 369 should be if (identifier !== MaxN) {

GalliumWang avatar Jan 25 '22 08:01 GalliumWang

You are right, I will check this out if I got some time. I'm pretty sure I've added the identifier === 0-check to fix some other bug that happened with Safari that time.

jonasstrehle avatar Jan 25 '22 09:01 jonasstrehle