osbuild icon indicating copy to clipboard operation
osbuild copied to clipboard

stages/rpm: support systemd-first-boot

Open teg opened this issue 4 years ago • 6 comments

The protocol described in machite-id(5) describes how ConditionFirstBoot is triggered in case /etc/machine-id does not exist during boot. Apart from triggering this condition, the behaviour is the same as when /etc/machine-id is empty.

When first-boot is set to true, /etc/machine-id is not created unless it existed. If first-boot is false (or unset) an empty /etc/machine-id is created as before.

I suggest using this in the interactive installer ISO, at least in case user configuration has not been specified.

teg avatar Feb 03 '22 18:02 teg

Can't we reuse our own first-boot implementation for this?

achilleas-k avatar Feb 03 '22 18:02 achilleas-k

Can't we reuse our own first-boot implementation for this?

Ah, yeah, that would work. Though as far as I recall the reason we did that at all was to avoid triggering systemd-first-boot.service, but as that's what we want here, I figured using the native thing would make more sense?

teg avatar Feb 03 '22 18:02 teg

Ah, yeah, that would work. Though as far as I recall the reason we did that at all was to avoid triggering systemd-first-boot.service, but as that's what we want here, I figured using the native thing would make more sense?

Probably would make more sense. I guess I'm curious why we don't use the native one for the other stuff as well.

achilleas-k avatar Feb 04 '22 00:02 achilleas-k

I guess I'm curious why we don't use the native one for the other stuff as well.

I think at the time I couldn't figure out how to ensure we didn't block on anything interactive during first boot. Though in this case that's exactly what we want :)

teg avatar Feb 04 '22 00:02 teg

Well this all makes sense to me

achilleas-k avatar Feb 04 '22 13:02 achilleas-k

I'm unlikely to have time to finish this up, feel free to take it over / consider it an RFE, if anyone is interested.

teg avatar May 16 '22 13:05 teg

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions[bot] avatar Sep 07 '23 04:09 github-actions[bot]

This PR represents a recurring issue with how we handle (and prevent) first-boot tasks. I don't know if this actual PR will be used in the end, but it's definitely something we need to figure out at some point. I'd rather we keep it open until we decide what to do with it.

achilleas-k avatar Sep 07 '23 16:09 achilleas-k

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 09 '23 04:10 github-actions[bot]

This PR was closed because it has been stalled for 30+7 days with no activity.

github-actions[bot] avatar Oct 16 '23 04:10 github-actions[bot]

I'm closing this because the continuation of this one (https://github.com/osbuild/osbuild/pull/1452) is now merged. Please reopen if I missed something here.

mvo5 avatar Dec 08 '23 09:12 mvo5