osbuild-composer icon indicating copy to clipboard operation
osbuild-composer copied to clipboard

osbuild-worker remote service is not restarted when a running compose is cancelled

Open stefbenoist opened this issue 1 year ago • 0 comments

Describe the bug Hi osbuild Team, When a running compose is cancelled with composer-cli compose cancel command,the osbuild-worker service is stopped due to this code: https://github.com/osbuild/osbuild-composer/blob/b6b399e55e483a088b47db553a300e3b7103c92f/cmd/osbuild-worker/main.go#L90.

But in case of remote worker, the systemd configuration file only sets Restart=on-failure: https://github.com/osbuild/osbuild-composer/blob/b6b399e55e483a088b47db553a300e3b7103c92f/distribution/osbuild-remote-worker%40.service#L9

So, the service won't restart in this case of successfully exit.

It's ok for a local worker: https://github.com/osbuild/osbuild-composer/blob/b6b399e55e483a088b47db553a300e3b7103c92f/distribution/osbuild-worker%40.service#L10

It's really not a big issue, just a little observation that may helps !

stefbenoist avatar Feb 08 '24 10:02 stefbenoist