osbuild-composer icon indicating copy to clipboard operation
osbuild-composer copied to clipboard

koji doesn't know the osbuild image build's task_id

Open azhuzhu opened this issue 3 years ago • 7 comments

Describe the bug koji doesn't know the osbuild image build's task_id, which is CG_imported from osbuild-composer.

Environment None

To Reproduce None

Expected behavior That would be better to add a field in ImageBuildExtra like 'koji_task_id' pointing to task_id of the osbuildImage task, so that koji web can parse it then get the task page link displayed.

Additional context None

azhuzhu avatar Apr 28 '22 09:04 azhuzhu

This makes sense. Though how do other content generators solve this? Sounds like there should be a unified way of exposing this information.

teg avatar Apr 28 '22 13:04 teg

OSBS currently uses 'container_koji_task_id' in build.extra which is similar to here we request. IMO, for osbuild, the key name could be more generic - 'koji_task_id'.

So, yes, there is no unified way yet - here is a koji issue to track this effort: https://pagure.io/koji/issue/215. Before it is implemented, we could follow the workaround approach as OSBS

azhuzhu avatar Apr 28 '22 14:04 azhuzhu

Sounds good to me, thanks! Who would be doing the work on the koji side to take advantage of this?

teg avatar Apr 28 '22 14:04 teg

I wrote an internal patch to support it, as it doesn't seem that osbuild is available for fedora koji

azhuzhu avatar Apr 28 '22 14:04 azhuzhu

fedora staging koji already has the osbuild plugin and it's coming to prod soon. :) See https://fedoraproject.org/wiki/Changes/IoTArtifactsWithOSBuild?rd=Changes/IoTArtefactsWithOSBuild

ondrejbudai avatar Apr 28 '22 16:04 ondrejbudai

ok, I will file a PR to koji

azhuzhu avatar May 03 '22 19:05 azhuzhu

FYI,

koji has supported setting task_id while CG-importing since 1.32, see

Issue: https://pagure.io/koji/issue/215 PR: https://pagure.io/koji/pull-request/3656

it can be specified as .build.task_id in the metadata now.

azhuzhu avatar Mar 24 '23 14:03 azhuzhu