image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard

Published 20 hours ago • verified publisher icon osbuild

internal/composer: reseek after lazy token refresh

Open croissanne opened this issue 10 months ago • 1 comments

croissanne avatar Apr 08 '24 10:04 croissanne

I do not like how this is copy-pasted around, I would suggest to create a dedicated type called LazyToken that would actually do the refreshing and it could also track expiration easily too, the information about expiration comes in the response. Then each client could create its own instance of this type to cleanly do lazy-initialized tokens when needed.

I am fine keeping status-quo tho, feel free to rebase I merged your big PR. Thanks.

lzap avatar Apr 09 '24 10:04 lzap

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 10 '24 04:05 github-actions[bot]

Anyway, this was a draft, feel free to rebase this is a correct fix.

lzap avatar May 14 '24 07:05 lzap