bootc-image-builder icon indicating copy to clipboard operation
bootc-image-builder copied to clipboard

lorax-templates-rhel conditional check applied too broadly

Open MoralCode opened this issue 1 year ago • 1 comments

f447421520010b1e46ab9d77605ab0afdcd101de from #489 implemented a check to ensure that the lorax-templates-rhel package is only included in the anaconda iso builds for distros that ship it. According to the commit message, the distros that have this are "EL-like distros and Fedora ELN".

However the check that was actually implemented reads c.SourceInfo.OSRelease.ID != "fedora" || c.SourceInfo.OSRelease.VersionID == "eln", which has the (presumably) unintended side effect of trying to include this EL-only package in ISO builds for any image that wants to be based on non-eln fedora, but have its own ID in /etc/os-release.

Until there is some way to collectively identify EL and EL-based distros (maybe via ID_LIKE=centos or something as discussed in similar issue #690), It would be nice to relax this if condition so the community can have an easier time building their own custom bootc images based on Fedora non-ELN

MoralCode avatar Oct 30 '24 03:10 MoralCode

This issue is stale because it had no activity for the past 365 days. Remove the "Stale" label or add a comment, otherwise this issue will be closed in 30 days.

github-actions[bot] avatar Oct 30 '25 04:10 github-actions[bot]