bootc-image-builder icon indicating copy to clipboard operation
bootc-image-builder copied to clipboard

bib: add new `--partition-mode` switch to enable lvm

Open mvo5 opened this issue 1 year ago • 2 comments

This allows us to quickly enable lvm. Draft as I think we need to decide on the UX, i.e. if this should be done via the blueprint config or commandline or both and how it interacts with --rootfs and btrfs.

This needs: ~https://github.com/osbuild/images/pull/876~ ~https://github.com/osbuild/osbuild/pull/1867~ ~https://github.com/osbuild/osbuild/pull/1862~

but with that I was able to:

$ bootc-image-builder manifest --partition-mode lvm quay.io/centos-bootc/centos-bootc:stream9
...
$ kvm -m 1500 -cpu host disk.raw
...
localhost login: root
Password: 
[systemd]
Failed Units: 1
  bootc-generic-growpart.service
[root@localhost ~]# mount|grep "/sysroot "
/dev/mapper/rootvg-rootlv on /sysroot type xfs (ro,relatime,seclabel,attr2,inode64,logbufs=8,logbsize=32k,noquota)

mvo5 avatar Aug 21 '24 16:08 mvo5

Failed Units: 1
  bootc-generic-growpart.service

should be fixed by https://gitlab.com/fedora/bootc/base-images/-/merge_requests/33

cgwalters avatar Aug 26 '24 19:08 cgwalters

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions[bot] avatar Oct 06 '24 04:10 github-actions[bot]

This would be great. Is this targeting any disk format (qcow2, raw, ami...)? (not taking into account ISO as we can use kickstart for that)

oglok avatar Oct 28 '24 14:10 oglok

This would be great. Is this targeting any disk format (qcow2, raw, ami...)? (not taking into account ISO as we can use kickstart for that)

Thanks for the feedback. This will land in slightly modified from directly via the "blueprints". The details are currently being worked on in https://github.com/osbuild/images/pull/926

mvo5 avatar Oct 28 '24 14:10 mvo5

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 28 '24 04:11 github-actions[bot]

This can be closed now that we have https://github.com/osbuild/bootc-image-builder/pull/725 - with 725 adding lvm/btrfs is now possible with much more control than it was with this prototype.

mvo5 avatar Nov 28 '24 07:11 mvo5

This would be great. Is this targeting any disk format (qcow2, raw, ami...)? (not taking into account ISO as we can use kickstart for that)

Ups, missed this question. Yes, the target is disk formats, and with the latest support in bib for arbitirary kicksart content the installer images should also be capable of doing this (but we won't translate the requests from the blueprint into kickstart files automatically)

mvo5 avatar Nov 28 '24 07:11 mvo5