bootc-image-builder icon indicating copy to clipboard operation
bootc-image-builder copied to clipboard

support s390x

Open cgwalters opened this issue 1 year ago • 11 comments

Copying the bits from here https://github.com/containers/bootc/issues/569 related to bib

It'd also be really great here to figure out how to share code w/Anaconda I'd say.

cgwalters avatar May 29 '24 14:05 cgwalters

What code would we share with Anaconda for this? Are we planning on building ISOs for s390x?

achilleas-k avatar May 30 '24 17:05 achilleas-k

@cgwalters I raised a PR https://github.com/osbuild/images/pull/758 for this issue.

We can add a partition table for s390x after the PR gets merged.

https://github.com/osbuild/bootc-image-builder/blob/61863ff3c39da79716b0a94945b153e58a138ca6/bib/cmd/bootc-image-builder/partition_tables.go#L24-L121

yoheiueda avatar Jun 24 '24 06:06 yoheiueda

@cgwalters @mvo5 @achilleas-k

I raised a PR https://github.com/osbuild/bootc-image-builder/pull/515 to include the latest images library that includes the fix for the issue reported above.

This PR also updates the setting for golangci-lint CI test to suppress a false-positive lint error.

yoheiueda avatar Jul 04 '24 06:07 yoheiueda

@cgwalters I created PR https://github.com/osbuild/bootc-image-builder/pull/553 to add support for s390x.

@achilleas-k For now, this PR enables QCOW2 only.

yoheiueda avatar Jul 19 '24 06:07 yoheiueda

I would like to add some smoke tests to bib for this - is there a quay.io container ref for a bootc enabled s390x container that I can use for testing?

mvo5 avatar Jul 29 '24 10:07 mvo5

@mvo5

I pushed quay.io/yoheiueda/fedora-bootc:latest. https://quay.io/repository/yoheiueda/fedora-bootc?tab=tags

I encountered several issues to build this image from the latest version of https://gitlab.com/fedora/bootc/base-images, so I manually modified the base image. I'll report the issues later.

yoheiueda avatar Jul 30 '24 07:07 yoheiueda

@mvo5

I pushed quay.io/yoheiueda/fedora-bootc:latest. https://quay.io/repository/yoheiueda/fedora-bootc?tab=tags

I encountered several issues to build this image from the latest version of https://gitlab.com/fedora/bootc/base-images, so I manually modified the base image. I'll report the issues later.

Thank you! I updated https://github.com/osbuild/bootc-image-builder/pull/566 to point to this container ref. When testing this (or clicking on the link above) I get a " Repository not found " error though, are these images maybe not set to public yet?

mvo5 avatar Jul 30 '24 07:07 mvo5

@mvo5 Sorry. I made it public.

yoheiueda avatar Jul 30 '24 07:07 yoheiueda

quay.io/fedora/fedora-bootc:41 is built for all 4 primary Fedora architectures since https://pagure.io/fedora-iot/pungi-iot/pull-request/78

cgwalters avatar Jul 30 '24 11:07 cgwalters

@cgwalters Thank you for the info. I tested quay.io/fedora/fedora-bootc:41 on my local environment, and it works fine.

Will the support of the additional architectures eventually come to fedora-40, centos-stream-9, and rhel-9?

BTW, I can't reproduce the issues I reported above any more in my environment, so please forgot it.

yoheiueda avatar Jul 30 '24 14:07 yoheiueda

Will the support of the additional architectures eventually come to fedora-40, centos-stream-9, and rhel-9?

https://gitlab.com/fedora/bootc/tracker/-/issues/15 will track the fedora/c{9,10s} efforts, and since CentOS Stream is RHEL it covers that too implicitly.

cgwalters avatar Aug 01 '24 20:08 cgwalters

@cgwalters Could you please close this issue unless any more change is necessary in this repo to support s390x? I understand that enablement of public container image builds are being tracked by the GitLab issue you mentioned.

yoheiueda avatar Sep 06 '24 05:09 yoheiueda

Thanks for all the work on this everyone!

cgwalters avatar Sep 06 '24 12:09 cgwalters