bootc-image-builder icon indicating copy to clipboard operation
bootc-image-builder copied to clipboard

Output directory confusing

Open cdrage opened this issue 1 year ago • 2 comments

Example:

        qcow2: 'qcow2/disk.qcow2',
        ami: 'image/disk.raw',
        raw: 'image/disk.raw',
        iso: 'bootiso/disk.iso',

Is where all the locations are.

But it should be:

        qcow2: 'qcow2/disk.qcow2',
        ami: 'ami/disk.raw',
        raw: 'raw/disk.raw',
        iso: 'iso/disk.iso',

Which makes more sense / predictable.

cdrage avatar Jan 10 '24 18:01 cdrage

A few new file formats were added since this GitHub Issue was originally created. Now the full list is:

  • ami and raw: image/disk.raw
  • anaconda-iso: bootiso/disk.iso
  • gce: gce/image.tar.gz
  • qcow2: qcow2/disk.qcow2
  • vhd: vpc/disk.vhd
  • vmdk: vmdk/disk.vmdk

LukeShortCloud avatar Dec 17 '24 00:12 LukeShortCloud

Fwiw, I would love to to see a --output flag that allows the caller to specify the filename, this way the caller can decide what it wants. There is some prereq work in https://github.com/osbuild/images/pull/1039 happening (but there are some code design questions still open)

mvo5 avatar Dec 18 '24 20:12 mvo5