blktests icon indicating copy to clipboard operation
blktests copied to clipboard

[draft]add new case for NVMe namespace management

Open yizhanglinux opened this issue 7 months ago • 3 comments

yizhanglinux avatar May 09 '25 17:05 yizhanglinux

Generally I would prefer if we would start using the JSON output instead the STDOUT of nvme-cli. The JSON output is there for machine parsing.

This would mean we add dependency on something like jq but IMO this would be better than continuing with the screen scraping.

igaw avatar May 12 '25 07:05 igaw

Generally I would prefer if we would start using the JSON output instead the STDOUT of nvme-cli. The JSON output is there for machine parsing.

This would mean we add dependency on something like jq but IMO this would be better than continuing with the screen scraping.

Thanks, just update to get the value from json ouput.

yizhanglinux avatar May 13 '25 01:05 yizhanglinux

Thanks for the patch. I have two comments:

  1. I wanted to confirm the motivation to add this test case . Does it aim to test the kernel code? Or nvme devices? If it aim to cover kernel code, which part of the kernel code, or which feature of the kernel to cover? (Namespace detection feature?)

  2. Can we ensure that the test target device status does not change before and after the test case run? For example, I wonder what will happen when multiple namespaces belong to a single controller, and one of the namespaces is the test target device.

kawasaki avatar May 13 '25 04:05 kawasaki