osjs-server icon indicating copy to clipboard operation
osjs-server copied to clipboard

Published 20 hours ago • verified publisher icon os-js

Add totalSize and totalCount values to VFS stats

Open mahsashadi opened this issue 2 years ago • 4 comments

Due to questions mentioned here, and also solutions provided here and here, we might need totalCount and totalSize in stats of directories.

mahsashadi avatar Aug 02 '22 09:08 mahsashadi

Just I cant not fix the unit-test of stats. Although stats work properly, there is some problem with totalSize which causes failing of the test.

mahsashadi avatar Aug 02 '22 09:08 mahsashadi

Hi again @andersevenrud Any more changes needed to do in this PR?

mahsashadi avatar Nov 23 '22 05:11 mahsashadi

@mahsashadi I've just been too busy to keep up with all of the PRs :(

I've made a notification in my calendar for this weekend so I can test and approve this.

andersevenrud avatar Nov 23 '22 15:11 andersevenrud

Hi again after long time. It will be great if we can approve these changes. Thanks. @andersevenrud @ajmeese7

mahsashadi avatar May 15 '23 11:05 mahsashadi