FOEDAG icon indicating copy to clipboard operation
FOEDAG copied to clipboard

Published 20 hours ago • verified publisher icon os-fpga

Since file path separator "/" is used everywhere it might not work on WIN.

Open KochynVolodymyr opened this issue 2 years ago • 8 comments

If search through the project "/" there are many entries. They are related to some paths. It might not work for the Window OS.

KochynVolodymyr avatar Jun 20 '22 13:06 KochynVolodymyr

Use std::filesystem::path apath = "a" / "b" / "c" ; the / operator will create the right separator automatically.

alain-rs avatar Jun 21 '22 22:06 alain-rs

@ravic-rs Checkout the summary of this issue on https://github.com/os-fpga/FOEDAG/issues/632#issuecomment-1269654578.

zaryabkhan-rs avatar Oct 06 '22 09:10 zaryabkhan-rs

@ravic-rs IP configurator is not working properly in Windows build. Screenshot windows FOEDAG build image

  • It doesn't show the IPs.
  • When Generate IP is pressed then No folder/files are created in project Directory.

Expected Output: Screenshot from Ubuntu FOEDAG Build @ravic-rs image

image

zaryabkhan-rs avatar Oct 07 '22 05:10 zaryabkhan-rs

@ravic-rs IP configurator is not working properly in Windows build. Screenshot windows build image

  • It doesn't show the IPs.
  • When Generate IP is pressed then No folder/files are created in project Directory.

We don't have any IPs available other than the Mock ones, I will let @skyler-rs comment on it.

ravic-rs avatar Oct 07 '22 05:10 ravic-rs

@ravic-rs IP configurator is not working properly in Windows build. Screenshot windows build image

  • It doesn't show the IPs.
  • When Generate IP is pressed then No folder/files are created in project Directory.

We don't have any IPs available other than the Mock ones, I will let @skyler-rs comment on it.

Yeah but we have two Mock Ips shows in ubuntu build. It also suppose to be shown in windows.

zaryabkhan-rs avatar Oct 07 '22 05:10 zaryabkhan-rs

We won't be able to tell if this breaks until Windows build is supported.

ravic-rs avatar Oct 07 '22 06:10 ravic-rs

@zaryabkhan-rs are there any errors printed in the tcl console? In particular, in foedag, which doesn't have a python venv installed, you should be seeing an error telling you a local python interpreter couldn't be found and then it printing what it found using LocateExecFile, but LocateExecFile fails on windows currently so my initial guess is this is failing at the finding python step, but can't be sure from that image.

It does look like the output Dir has a bad path display; however, i think i hardened the actual filepaths at the script execution point, but I can definitely look into fixing it earlier at this point as well.

I haven't tried a windows build recently, but as @ravic-rs mentions, eventually i'll probably need to build and debug this in windows so that could be a gating factor.

skyler-rs avatar Oct 07 '22 14:10 skyler-rs

Use the filesystem class separator operator that works on all OSs. There are plenty of working example code in the Compiler subsystem.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: zaryabkhan-rs @.> Sent: Thursday, October 6, 2022 10:38:41 PM To: os-fpga/FOEDAG @.> Cc: Alain Dargelas @.>; Comment @.> Subject: Re: [os-fpga/FOEDAG] Since file path separator "/" is used everywhere it might not work on WIN. (Issue #473)

IP configurator is not working properly in Windows build. Screenshot windows build [image]https://user-images.githubusercontent.com/109368108/194475171-cab54c76-8402-47d4-aae8-eb9d9a7335b0.png

  • It doesn't show the IPs.
  • When Generate IP is pressed then, No folder/files are created in project Directory.

— Reply to this email directly, view it on GitHubhttps://github.com/os-fpga/FOEDAG/issues/473#issuecomment-1271132468, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVTRKPMDYO46YTUY4KWEWLLWB6ZODANCNFSM5ZI3O3QQ. You are receiving this because you commented.Message ID: @.***>

alain-rs avatar Oct 07 '22 15:10 alain-rs