os-autoinst-distri-opensuse
os-autoinst-distri-opensuse copied to clipboard
os-autoinst
Add CI check to prevent the use of root-console when serial-terminal could be used
See: https://progress.opensuse.org/issues/153805 VR: https://openqa.suse.de/tests/overview?build=os-autoinst%2Fos-autoinst-distri-opensuse%2318816
@okurz Yes, the ticket mentions that the check could be skipped in certain cases (such as ncurses), I'm still working on it. Or are you suggesting that the check should not be implemented at all?
Acceptance criteria: A format is considered to allow or skip the rule check purposefully
@okurz Yes, the ticket mentions that the check could be skipped in certain cases (such as ncurses), I'm still working on it. Or are you suggesting that the check should not be implemented at all?
I am not sure it's feasible to do that check. git grep -l 'use.*consoletest' | wc -l says there are currently 636 files using consoletest. Out of these according to git grep -l 'use.*consoletest' | xargs grep assert_screen | wc -l 456 files use assert_screen. Did you check those?
@okurz Yes, the ticket mentions that the check could be skipped in certain cases (such as ncurses), I'm still working on it. Or are you suggesting that the check should not be implemented at all?
I am not sure it's feasible to do that check.
git grep -l 'use.*consoletest' | wc -lsays there are currently 636 files using consoletest. Out of these according togit grep -l 'use.*consoletest' | xargs grep assert_screen | wc -l456 files useassert_screen. Did you check those?
No, I exclusively checked tests which use consoletest (not y2_module_consoletest as included in your search). According to git grep -lE 'use base ("|\')consoletest' | xargs grep -l assert_screen | wc -l there are 30 files. But still, it looks like their use of assert_screen is justified.
@cedvid you keep pushing changes which is nice to see but I am always getting a notification and no message by you about what changed since the last time. I wonder what the intention is: Should we review the actual changes now?
EDIT: Unsubscribed due to no response