os-autoinst-distri-opensuse icon indicating copy to clipboard operation
os-autoinst-distri-opensuse copied to clipboard

Published 20 hours ago • verified publisher icon os-autoinst

Double confirm smt-mirror can pass

Open rfan1 opened this issue 2 years ago • 9 comments

Due to bsc#1201738, enhance current logic to double check the log file to make sure smt-mirror passes without error

  • Related ticket: https://progress.opensuse.org/issues/114403
  • Verification run: http://openqa.suse.de/t9207330 http://openqa.suse.de/t9207331 http://openqa.suse.de/t9207332

rfan1 avatar Jul 21 '22 13:07 rfan1

@rfan1 can you provide a VR where the error is properly detected?, I'm not sure about the regexp

foursixnine avatar Jul 25 '22 08:07 foursixnine

@rfan1 can you provide a VR where the error is properly detected?, I'm not sure about the regexp

http://openqa.suse.de/t9207330 http://openqa.suse.de/t9207331 http://openqa.suse.de/t9207332

rfan1 avatar Jul 25 '22 08:07 rfan1

@rfan1 can you provide a failing case?

foursixnine avatar Jul 25 '22 10:07 foursixnine

@rfan1 can you provide a failing case?

http://openqa.suse.de/tests/9171525#step/system_prepare/5

But, I don't have any job can explain without "sync" cmd, the job failed one. however, I think it makes sense we issue "sync" command

rfan1 avatar Jul 25 '22 10:07 rfan1

@rfan1 can you provide a failing case?

Let me try to set the disk size to 40GB and trigger a failed job then, hold on the merge process

rfan1 avatar Jul 25 '22 10:07 rfan1

It's not really a regex, more of a string match. It may fail in the future but it will fail loudly and we can attempt a regex then. If @foursixnine doesn't still object I think we should merge.

a-kpappas avatar Jul 25 '22 11:07 a-kpappas

@rfan1 can you provide a failing case?

Let me try to set the disk size to 40GB and trigger a faild job then, hold on the merge process

http://openqa.suse.de/tests/9208875#step/smt_server_install/57

BTW, I did some modification and executed the "df -h" command prior to log check, then we can check the disk full error easily

rfan1 avatar Jul 25 '22 14:07 rfan1

It's not really a regex, more of a string match. It may fail in the future but it will fail loudly and we can attempt a regex then. If @foursixnine doesn't still object I think we should merge.

@a-kpappas VR provided

rfan1 avatar Jul 25 '22 14:07 rfan1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If it's still needed, you can add labels WIP or notready to it

stale[bot] avatar Oct 29 '22 03:10 stale[bot]

@rfan1 Do we want to continue working on this?

foursixnine avatar Dec 05 '22 17:12 foursixnine

@rfan1 Do we want to continue working on this?

@foursixnine I would hold on this PR:

  1. the issue was not seen any more after increasing the disk size to 100gb.
  2. My codes are too strict to check the error messages due to bsc#1201738

rfan1 avatar Dec 06 '22 02:12 rfan1