openQA icon indicating copy to clipboard operation
openQA copied to clipboard

WIP: More signatures

Open okurz opened this issue 1 year ago • 2 comments

  • Simplify Resource::Locks with direct return of boolean calculations
  • Use signatures in Resource::Locks
  • Slightly simplify script/openqa-validate-yaml
  • Use signatures in WebAPI::ServerSideDataTable
  • Use signatures in Resource::Jobs

okurz avatar Mar 14 '24 08:03 okurz

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.39%. Comparing base (1a01d2d) to head (b295d47). Report is 2029 commits behind head on master.

Files with missing lines Patch % Lines
script/openqa-validate-yaml 0.00% 2 Missing :warning:

:x: Your patch status has failed because the patch coverage (87.50%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5511   +/-   ##
=======================================
  Coverage   98.38%   98.39%           
=======================================
  Files         391      391           
  Lines       37883    37874    -9     
=======================================
- Hits        37271    37265    -6     
+ Misses        612      609    -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 14 '24 09:03 codecov[bot]

This pull request is now in conflicts. Could you fix it? 🙏

mergify[bot] avatar Apr 15 '24 14:04 mergify[bot]

These changes have all been done meanwhile, so I'll close this

perlpunk avatar Jul 20 '25 15:07 perlpunk