openQA icon indicating copy to clipboard operation
openQA copied to clipboard

Use perlcritic from os-autoinst-common

Open b10n1k opened this issue 1 year ago • 3 comments

OpenQA is ready for adapt the perlcriticrc from os-autoinst-common.

https://progress.opensuse.org/issues/138416

b10n1k avatar Feb 07 '24 10:02 b10n1k

I update the os-autoinst-common as the checkstyle keeps failing https://github.com/os-autoinst/openQA/pull/5465

b10n1k avatar Feb 09 '24 08:02 b10n1k

s/commom/common/

okurz avatar Feb 09 '24 08:02 okurz

@b10n1k Please consider this open suggestion, and there is a CI check failing:

::warning file=lib/OpenQA/WebAPI/Controller/Test.pm,line=99,col=5,title=Hash key with quotes - severity 5::[HashKeyQuotes] Avoid useless quotes

Maybe consider https://github.com/os-autoinst/os-autoinst-common/pull/42 here?

s/commom/common/

kalikiana avatar Feb 14 '24 09:02 kalikiana