Stop setting NOVIDEO=1 for longer jobs

[Vogtinator]

Videos are not that big even if the job is running longer than whatever the "default" is resp. the maximum time is. They are very valuable for debugging failed tests and even more useful in the case of those longer running tests, like upgrade scenarios.

[github-actions[bot]]

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

• [ ] Consider generating documentation locally to verify it is rendered correctly using tools/generate-htmldoc

This is an automatically generated QA checklist based on modified files

[Vogtinator]

I think we had a good reason for doing this, although it was mainly about OSD.

Can you elaborate on this?

[Martchus]

We were running out of disk space on OSD, see tickets referenced on the PR that introduced the feature (https://github.com/os-autoinst/openQA/pull/3112). That wasn't the first alert of that kind. Before, we frequently deleted old video manually. The videos unfortunately did make a significant different. (On OSD there are unfortunately more long-running tests and some are really running extensively run.)

[Vogtinator]

Maybe just manually set NOVIDEO=0 in those cases if it's specific to certain tests on that instance?

[Martchus]

You don't actually think that test maintainers would be disciplined enough to put NOVIDEO=0 in certain test scenarios appropriately. Having to enable the video manually might be tedious but it forced people to think at least for one second whether they actually need the video (or the long test runtime).

[okurz]

I agree that videos are important. But simply reverting doesn't cut it. If you want to help I suggest to do https://progress.opensuse.org/issues/77842 "Use external videoencoder in production on all o3 machines" first to actually have smaller videos, then we can enable videos again.

I also think having this configurable per instance is a good idea. I would keep videos enabled on o3 and disable on osd if above MAX_JOB_TIME.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mergify[bot]]

This pull request is now in conflicts. Could you fix it? 🙏

[mergify[bot]]

This pull request is now in conflicts. Could you fix it? 🙏