x icon indicating copy to clipboard operation
x copied to clipboard
verified publisher icon ory

feat: upgrade OTEL

Open vivshankar opened this issue 1 year ago • 5 comments

Given the request made in ory/fosite#809, this PR proposes upgrading the OTEL modules to the latest version (v1.29.0).

Related Issue or Design Document

ory/fosite#809

Checklist

  • [x] I have read the contributing guidelines and signed the CLA.
  • [x] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added the necessary documentation within the code base (if appropriate).

Further comments

N/A

vivshankar avatar Sep 04 '24 18:09 vivshankar

In the past, opentelemetry regularly introduces backwards-incompatible changes to their SDKs in minor releases. Have you checked if Hydra+Keto+Kratos+Oathkeeper work with this new version?

alnr avatar Sep 09 '24 10:09 alnr

@alnr I have tested with Fosite's unit tests and haven't seen any issues. I have not tried this with Hydra or the other products. I don't have those running locally.

vivshankar avatar Sep 09 '24 10:09 vivshankar

@alnr Can this move forward? I have tested this with Fosite and it works.

vivshankar avatar Sep 12 '24 21:09 vivshankar

I don't have capacity right now to verify this doesn't cause upgrade issues in kratos/keto/hydra/oathkeeper.

alnr avatar Sep 13 '24 07:09 alnr

Interestingly, Hydra is already at v1.28 - https://github.com/ory/hydra/blob/master/go.mod#L60C2-L63C40

vivshankar avatar Sep 14 '24 02:09 vivshankar

bumped in v0.0.672

alnr avatar Nov 27 '24 11:11 alnr