oathkeeper icon indicating copy to clipboard operation
oathkeeper copied to clipboard

create custom forward request authenticator

Open vladr11 opened this issue 3 years ago • 7 comments

Adds a new authenticator which forwards the requests to an upstream service to perform the authentication. This adds the possibility to authenticate a request where the request body is needed.

Related issue(s)

Related to issue #841

Checklist

  • [x] I have read the contributing guidelines.
  • [x] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I am following the contributing code guidelines.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security. vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [x] I have added or changed the documentation.

vladr11 avatar Apr 04 '22 08:04 vladr11

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 04 '22 08:04 CLAassistant

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (6e3844e) 78.05% compared to head (53ead8f) 77.57%. Report is 126 commits behind head on master.

Files Patch % Lines
pipeline/authn/authenticator_remote_json.go 60.41% 29 Missing and 9 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   78.05%   77.57%   -0.49%     
==========================================
  Files          83       84       +1     
  Lines        3992     4089      +97     
==========================================
+ Hits         3116     3172      +56     
- Misses        597      628      +31     
- Partials      279      289      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 04 '22 13:04 codecov[bot]

Not sure if you have done that already, but could you also please create a PR against ory/docs to document this new functionality? :)

Created a new PR into ory/docs: https://github.com/ory/docs/pull/827

vladr11 avatar May 24 '22 15:05 vladr11

A polite reminder here, as the change requests have been addressed 😄

Fixed linting issues, as well.

vladr11 avatar Jun 30 '22 11:06 vladr11

A polite ping here again 😉

jendrikjoe avatar Sep 01 '22 15:09 jendrikjoe

@hperl could you please help review this one? :)

aeneasr avatar Sep 10 '22 08:09 aeneasr