oathkeeper icon indicating copy to clipboard operation
oathkeeper copied to clipboard

Published 20 hours ago • verified publisher icon ory

Support gzipped responses in check session URLs

Open aeneasr opened this issue 3 years ago • 4 comments

Describe the bug

See https://github.com/ory/oathkeeper/pull/835

aeneasr avatar Sep 27 '21 13:09 aeneasr

If a request manually sets the Accept-Encoding header the transport will not automatically decode the response.

https://pkg.go.dev/net/http#Transport.DisableCompression

Currently, it looks like oathkeeper copies all the headers from the original request so if the original request has the Accept-Encoding header the body will not decompressed.

https://github.com/ory/oathkeeper/blob/9375f92b5d647c8417389158bf66e060b4ab8ad6/pipeline/authn/authenticator_cookie_session.go#L152

dreverri avatar Sep 28 '21 14:09 dreverri

Ah, I see, that makes sense!

aeneasr avatar Oct 03 '21 10:10 aeneasr

@aeneasr PR coming soon. We somehow hit that.

till avatar Feb 09 '22 10:02 till