Hide recovery and registration links on login page when those flows are disabled
Preflight checklist
- [X] I could not find a solution in the existing issues, docs, nor discussions.
- [X] I agree to follow this project's Code of Conduct.
- [X] I have read and am following this repository's Contribution Guidelines.
- [X] This issue affects my Ory Network project.
- [X] I have joined the Ory Community Slack.
- [X] I am signed up to the Ory Security Patch Newsletter.
Describe your problem
When disabling the recovery and registration flows the Account Experience needs hide the links on the page that navigate the user to the registration and recovery page.
Describe your ideal solution
Call the registration and recovery endpoints in the background when the login page is shown to verify if the recovery and registration pages are enabled.
Workarounds or alternatives
None.
Version
latest
Additional Context
No response
Hello contributors!
I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue
- open a PR referencing and resolving the issue;
- leave a comment on it and discuss ideas on how you could contribute towards resolving it;
- leave a comment and describe in detail why this issue is critical for your use case;
- open a new issue with updated details and a plan for resolving the issue.
Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.
Unfortunately, burnout has become a topic of concern amongst open-source projects.
It can lead to severe personal and health issues as well as opening catastrophic attack vectors.
The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.
If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.
Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!
Thank you 🙏✌️
@jonas-jonas is this done already?
This will be available in the new account experience.
@jonas-jonas Can you confirm that this will be available in the new account experience? One of our devs tried it but it still doesn't seem to be fixed. Can you please provide a workaround in the meantime?
Hello, we can't give out timelines unfortunately but the release of the new Ory Elements can be followed in: https://github.com/ory/elements
You can also enable the new account experience as an experiment in your project under "branding"
@aeneasr thanks for the reply. I didn't ask for a time estimate, just whether or not it's a fix that will be included in the new account experience or not. As I said, one of our devs has already tried the new account experience but found that it's not fixed there yet either. Is there a workaround for this issue that you can provide in the mean time? As stated in the initial issue the deactivation of recovery and registration flows are not respected by the Ory account experience login page and thus show up when they should not.
Can't reproduce, if i turn off registration, the link disappears:
If I turn it on it is there:
What are you looking for exactly?
Same for recovery - disabled
Enabled
All of this is on prod - closing this issue.
@aeneasr Is this considered fixed if the fix is only available in a new experimental feature? I'm not comfortable enabling the new account experience on production just to fix this issue if it's still classed as "Experimental" and I assume you wouldn't recommend it either?
This won't be backported to the current version of the account experience.
That didn't really answer any of my questions and nor have you provided a workaround. Not great from a paying customer's perspective to be honest. I guess we're just stuck with a buggy Ory Account Experience until the new one is released, which you can't give me a timeline for.....
If you have an Account Executive, you can contact them to get more details. I'm sure you understand that we can't publicly commit to timelines. This repository serves for self-service customers or known issues, it's not our internal issue tracker or roadmap planner.
@aeneasr Still cannot reproduce your findings on the old or new account experience:
If I click on the "Sign Up" link it takes me here:
You need to restart a new registration flow
I've tried that 3 times. I can see 3 different flow IDs in the query parameter of the url. I also tried disabling the new account experience and re-enabling it, no change.
Thank you for the report! It looks like this worked for a while, and now has a regression after we shipped 2FA in the new elements.
@aeneasr no problem, thanks for reopening the ticket and acting quickly