kratos icon indicating copy to clipboard operation
kratos copied to clipboard

fix: get additional user claims from Microsoft graph API

Open alnr opened this issue 1 year ago • 1 comments

#3609 Introduced a bug where the subject could not be established from the GraphAPI response. This change fixes that, and also keeps the old way of querying the API as a fallback if anything goes wrong.

alnr avatar Jan 30 '24 13:01 alnr

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (84149c4) 78.33% compared to head (05734ed) 78.28%. Report is 4 commits behind head on master.

Files Patch % Lines
selfservice/strategy/oidc/provider_microsoft.go 57.57% 7 Missing and 7 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
- Coverage   78.33%   78.28%   -0.05%     
==========================================
  Files         347      347              
  Lines       23815    23831      +16     
==========================================
+ Hits        18655    18657       +2     
- Misses       3750     3760      +10     
- Partials     1410     1414       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 14:01 codecov[bot]