kratos icon indicating copy to clipboard operation
kratos copied to clipboard

feat: add `upstream_parameters` to oidc providers config

Open splaunov opened this issue 1 year ago • 1 comments

While upstream parameters are already supported as part of a user request, sometimes there is a need to set them as a static values in a provider config.

Related issue(s)

https://github.com/ory/kratos/pull/3138

Checklist

  • [x ] I have read the contributing guidelines.
  • [x ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x ] I am following the contributing code guidelines.
  • [x ] I have read the security policy.
  • [x ] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got the approval (please contact [email protected]) from the maintainers to push the changes.
  • [x ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added or changed the documentation.

Further Comments

splaunov avatar Nov 28 '23 05:11 splaunov

Codecov Report

Attention: Patch coverage is 29.41176% with 36 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (1a70648) to head (9bdd544). Report is 9 commits behind head on master.

:exclamation: Current head 9bdd544 differs from pull request most recent head ebdb06b

Please upload reports for the commit ebdb06b to get more accurate results.

Files Patch % Lines
selfservice/strategy/oidc/provider_discord.go 0.00% 3 Missing :warning:
selfservice/strategy/oidc/provider_patreon.go 0.00% 3 Missing :warning:
selfservice/strategy/oidc/provider_apple.go 0.00% 2 Missing :warning:
selfservice/strategy/oidc/provider_dingtalk.go 0.00% 2 Missing :warning:
selfservice/strategy/oidc/provider_generic_oidc.go 75.00% 1 Missing and 1 partial :warning:
selfservice/strategy/oidc/provider_github.go 0.00% 2 Missing :warning:
selfservice/strategy/oidc/provider_github_app.go 0.00% 2 Missing :warning:
selfservice/strategy/oidc/provider_google.go 60.00% 1 Missing and 1 partial :warning:
selfservice/strategy/oidc/provider_lark.go 0.00% 2 Missing :warning:
selfservice/strategy/oidc/provider_linkedin.go 0.00% 2 Missing :warning:
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3644      +/-   ##
==========================================
+ Coverage   78.10%   78.36%   +0.25%     
==========================================
  Files         362      344      -18     
  Lines       25329    23516    -1813     
==========================================
- Hits        19783    18428    -1355     
+ Misses       4028     3699     -329     
+ Partials     1518     1389     -129     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 05:11 codecov[bot]