kratos icon indicating copy to clipboard operation
kratos copied to clipboard

feat: added Econt as OIDC Provider

Open peturgeorgievv opened this issue 2 years ago • 2 comments

This PR is intending to implement another OIDC provider for Econt a Bulgarian common provider to Kratos since Econt has non-standard paths to its auth and token endpoints.

Related issue(s)

There is no issue as this is just a new OIDC provider.

Checklist

  • [x] I have read the contributing guidelines.
  • [ ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I am following the contributing code guidelines.
  • [ ] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got the approval (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added or changed the documentation.

Further Comments

I added econt as OIDC Provider, as we already have it implemented in our project and it would be good to not have a kratos-fork for it.

peturgeorgievv avatar Jan 30 '23 10:01 peturgeorgievv

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 30 '23 10:01 CLAassistant

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes are missing coverage. Please review.

Project coverage is 76.87%. Comparing base (44556a4) to head (7ebb0ca). Report is 551 commits behind head on master.

Files Patch % Lines
selfservice/strategy/oidc/provider_econt.go 0.00% 102 Missing :warning:
selfservice/strategy/oidc/provider_config.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
- Coverage   77.28%   76.87%   -0.41%     
==========================================
  Files         313      314       +1     
  Lines       19552    19656     +104     
==========================================
  Hits        15110    15110              
- Misses       3274     3378     +104     
  Partials     1168     1168              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '23 10:01 codecov[bot]